Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error when function as llm_config passed to GroupChatManager #911

Merged
merged 9 commits into from
Dec 10, 2023
Merged

Raise error when function as llm_config passed to GroupChatManager #911

merged 9 commits into from
Dec 10, 2023

Conversation

yiranwu0
Copy link
Collaborator

@yiranwu0 yiranwu0 commented Dec 7, 2023

  1. Raise error when function as llm_config passed to GroupChatManager
  2. Add test in test_function_call_groupchat.py.
  3. Handling undesired case when selector is returning a function_call instead of str name.

Why are these changes needed?

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70f4c1c) 26.73% compared to head (ab97630) 48.59%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #911       +/-   ##
===========================================
+ Coverage   26.73%   48.59%   +21.85%     
===========================================
  Files          28       28               
  Lines        3766     3768        +2     
  Branches      853      896       +43     
===========================================
+ Hits         1007     1831      +824     
+ Misses       2686     1752      -934     
- Partials       73      185      +112
Flag Coverage Δ
unittests 48.38% <100.00%> (+21.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonichi
sonichi reviewed Dec 7, 2023
View reviewed changes
autogen/agentchat/groupchat.py Outdated Show resolved Hide resolved
test/agentchat/test_function_call_groupchat.py Outdated Show resolved Hide resolved
@yiranwu0 yiranwu0 requested a review from sonichi December 7, 2023 18:55
@sonichi sonichi added this pull request to the merge queue Dec 10, 2023
Merged via the queue into main with commit fd84ef1 Dec 10, 2023
79 of 84 checks passed
@sonichi sonichi deleted the fixgroupchat branch December 10, 2023 03:07
rlam3 pushed a commit to rlam3/autogen that referenced this pull request Dec 19, 2023
@yiranwu0 @rlam3
Raise error when function as llm_config passed to GroupChatManager (m…
833ecb7 
…icrosoft#911)

* fix groupchat selection

* update

* update notbooks

* update

* update
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@yiranwu0
Raise error when function as llm_config passed to GroupChatManager (m…
d25c1db 
…icrosoft#911)

* fix groupchat selection

* update

* update notbooks

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonichi sonichi sonichi left review comments

@afourney afourney afourney approved these changes

@thinkall thinkall Awaiting requested review from thinkall

@qingyun-wu qingyun-wu Awaiting requested review from qingyun-wu

@gagb gagb Awaiting requested review from gagb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiranwu0 @codecov-commenter @afourney @sonichi